Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor bugfix: don't truncate the extension in conda-meta filenames #744

Merged
merged 2 commits into from
Nov 7, 2024

Conversation

maresb
Copy link
Contributor

@maresb maresb commented Nov 7, 2024

Description

Conda-lock constructs a fake conda-meta directory containing a .json metadata for each package in a lockfile. A typical .json looks like

{
  "name": "astropy",
  "channel": "conda-forge",
  "url": "https://conda.anaconda.org/conda-forge/linux-64/astropy-5.0-py39hce5d2b2_0.tar.bz2",
  "md5": "5a2d9b5961e84cbbac615c2e3fb7e456",
  "build": "py39hce5d2b2_0",
  "build_number": 0,
  "version": "5.0",
  "subdir": "linux-64",
  "fn": "astropy-5.0-py39hce5d2b2_0.tar.bz2",
  "depends": [
    "importlib-metadata",
    "libgcc-ng >=9.4.0",
    "numpy >=1.19.5,<2.0a0",
    "packaging >=19.0",
    "pyerfa >=2.0",
    "python >=3.9,<3.10.0a0",
    "python_abi 3.9.* *_cp39",
    "pyyaml >=3.13"
  ]
}

Before this change, the fn entry was missing the .tar.bz2 extension. This was leading to problems with micromamba v2 which apparently strengthened the validation logic a bit.

@maresb maresb requested a review from a team as a code owner November 7, 2024 20:07
Copy link

netlify bot commented Nov 7, 2024

Deploy Preview for conda-lock ready!

Name Link
🔨 Latest commit d1cefab
🔍 Latest deploy log https://app.netlify.com/sites/conda-lock/deploys/672d1e1acac9fd0008df87c7
😎 Deploy Preview https://deploy-preview-744--conda-lock.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@maresb maresb merged commit d65aad5 into conda:main Nov 7, 2024
42 of 43 checks passed
@maresb maresb deleted the fix-fake-conda-env branch November 7, 2024 20:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant