Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Getting test dependencies from extras #429

Closed
jakirkham opened this issue Jan 25, 2023 · 1 comment · Fixed by #432
Closed

Getting test dependencies from extras #429

jakirkham opened this issue Jan 25, 2023 · 1 comment · Fixed by #432
Labels
enhancement New feature or request good first issue Good for newcomers python

Comments

@jakirkham
Copy link
Member

jakirkham commented Jan 25, 2023 •
edited
Loading

AFAIK there is no standard for handling testing dependencies (with test_requires being dropped ( pypa/setuptools#931 )). That said, have seen testing, test, and tests. Currently Grayskull checks one approach. Though maybe all of them should be checked.

https://github.com/conda-incubator/grayskull/blob/d17444d66ebf50fdb5d97948c7ecfc654b0f68fa/grayskull/strategy/pypi.py#L168

https://github.com/conda-incubator/grayskull/blob/d17444d66ebf50fdb5d97948c7ecfc654b0f68fa/grayskull/strategy/py_toml.py#L22-L24
@marcelotrevisani marcelotrevisani added enhancement New feature or request good first issue Good for newcomers python labels Jan 25, 2023
@marcelotrevisani
Copy link
Member

Indeed! It should check all the options, thanks for the heads up!

@marcelotrevisani marcelotrevisani linked a pull request Jan 28, 2023 that will close this issue
Look for metadata test with section named 'test', 'tests' or 'testing' #432
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request good first issue Good for newcomers python
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Look for metadata test with section named 'test', 'tests' or 'testing' conda/grayskull
2 participants
@jakirkham @marcelotrevisani