Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PRs in Triaging/Backlog/Sprint #515

Closed
kenodegard opened this issue Feb 8, 2022 · 2 comments
Closed

PRs in Triaging/Backlog/Sprint #515

kenodegard opened this issue Feb 8, 2022 · 2 comments
Assignees
Labels
in-progress issue is actively being worked on locked [bot] locked due to inactivity source::anaconda created by members of Anaconda, Inc. type::task indicates a change that doesn't pertain to the code itself, e.g. updating CI/CQ, rebuilding package

Comments

@kenodegard
Copy link
Contributor

State of Affairs

  • Issues are automatically added to the triaging board and is lead through triage and into the backlog during the team's refinement
  • PRs are ignored in this process, we do not require triaging & labeling PRs

Where do PRs belong within our Triaging/Backlog/Sprint process?

Proposal 1

Require all PRs to have an associated issue that has been triaged and refined.

Pros Cons
PRs are simply "handled" by existing processes Barrier to entry
Contributors don't care about our planning process

Personally, I feel this has too high of a barrier to entry and hence should be ruled out.

Proposal 2

New Kanban board for PRs.

Pros Cons
Clean distinction between an issue and a PR Defines a whole new process
Who is responsible for monitoring/moving PRs through the board

Proposal 3

Improve PR templates. Offer 4 PR template flavors:

  • Linked Issue: A template based around there being an existing Issue that has already been triaged
  • Bug Fix: A bug fix template for a contribution that doesn't seek to resolve an existing Issue
  • Feature Implementation: A feature implementation template for a contribution that doesn't seek to resolve an existing Issue
  • For conda-core Only: A blank template with a blurb stating that if any non-conda-core users use this template that the contribution will be immediately rejected (this is probably unnecessary since we should (?) assume that any conda-core PR will have had a proper issue opened ahead of time)
Pros Cons
Ensures all contributions include full background info Barrier to entry (but it feels lower than Proposal 1)
@kenodegard kenodegard added source::anaconda created by members of Anaconda, Inc. type::task indicates a change that doesn't pertain to the code itself, e.g. updating CI/CQ, rebuilding package backlog issue has been triaged but has not been earmarked for any upcoming release labels Feb 8, 2022
@kenodegard kenodegard self-assigned this May 11, 2022
@kenodegard kenodegard added in-progress issue is actively being worked on and removed backlog issue has been triaged but has not been earmarked for any upcoming release labels May 11, 2022
@kenodegard
Copy link
Contributor Author

Rolled out a new Planning board that includes a view for open PRs, this effectively implements proposal 2 above.

@kenodegard
Copy link
Contributor Author

We will continue experimenting with the new Planning board but otherwise, this has been completed.

Additional work should be done to roll out consistent issue/PR templates for all repos.

@github-actions github-actions bot added the locked [bot] locked due to inactivity label Jun 3, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 3, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
in-progress issue is actively being worked on locked [bot] locked due to inactivity source::anaconda created by members of Anaconda, Inc. type::task indicates a change that doesn't pertain to the code itself, e.g. updating CI/CQ, rebuilding package
Projects
Archived in project
Development

No branches or pull requests

1 participant