Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provide standard interface on RemoteAccount for getting a hostname that can be used from the test driver #129

Open
ewencp opened this issue Nov 12, 2015 · 1 comment

Comments

@ewencp
Copy link
Contributor

ewencp commented Nov 12, 2015

Currently VagrantCluster sets up externally_routable_ip, but this field isn't included for other cluster types and its naming is very unclear. We should standardize what needs to be provided, and RemoteAccount can help out by handling the common case where hostname and the hostname used by the driver machine are the same.

Note that ssh_hostname isn't sufficient because on virtualbox vagrant clusters that value is always 127.0.0.1. ssh_hostname also isn't ideal for AWS clusters because it uses the public IP, but generally the driver is running in AWS as well and can use the AWS-internal IP that doesn't cost money for bandwidth.

@ewencp
Copy link
Contributor Author

ewencp commented Nov 12, 2015

Maybe also document what all the fields in RemoteAccount mean because having hostname, ssh_hostname, and externally_routable_ip will be very confusing for new users.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant