Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace io.confluent.kafka.serializers.AbstractKafkaAvroSerDeConfig with AbstractKafkaSchemaSerDeConfig #336

Closed
ybyzek opened this issue May 5, 2020 · 16 comments
Labels

Comments

@ybyzek
Copy link
Contributor

ybyzek commented May 5, 2020

Warning during compile:

io.confluent.kafka.serializers.AbstractKafkaAvroSerDeConfig in io.confluent.kafka.serializers has been deprecated

Resolve: use new class: https://github.com/confluentinc/schema-registry/blob/5.5.0-post/schema-serializer/src/main/java/io/confluent/kafka/serializers/AbstractKafkaSchemaSerDeConfig.java

@ybyzek ybyzek added the bug label May 5, 2020
@rspurgeon rspurgeon self-assigned this Jun 23, 2020
@rspurgeon
Copy link
Contributor

I'm addressing this as part of some changes for running the microservices against cloud

@ybyzek
Copy link
Contributor Author

ybyzek commented Sep 29, 2020

@rspurgeon is this GH issue resolved by https://github.com/confluentinc/kafka-streams-examples/pull/346/files ? If so, can you please mark Closed?

@rspurgeon
Copy link
Contributor

@ybyzek I wasn't able to get this resolved across the entire repo, so I left this issue open.

@ybyzek
Copy link
Contributor Author

ybyzek commented Sep 29, 2020

@rspurgeon Are you planning to resolve this across the entire repo? If not, you can unassign yourself from the issue.

@rspurgeon rspurgeon removed their assignment Sep 29, 2020
@saurabh-slacklife
Copy link
Contributor

@ybyzek I don't mind picking this up and I can see deprecated warning at 34 different places - for entire repo. Let me know if I can and also the version to push to(6.0.1-post?)

Thanks.

@ybyzek
Copy link
Contributor Author

ybyzek commented Mar 24, 2021

@saurabh-slacklife -- that would be 🆒 , thanks! At this time, 6.1.1-post is the latest, so I would recommend working off that branch.

@saurabh-slacklife
Copy link
Contributor

@saurabh-slacklife -- that would be 🆒 , thanks! At this time, 6.1.1-post is the latest, so I would recommend working off that branch.

Acknowledged.

@saurabh-slacklife
Copy link
Contributor

There are certain more Java related deprecated warnings:

  1. Usage of "schema.registry.basic.auth.user.info". From Confluent 5.0 "schema.registry" was dropped and per the Compatibility Matrix, the current code branch is compatible with Confluent 5.4, therefore I believe this should also be updated.
  2. Certain state store methods in KafkaStreams.

Not sure if you would like these to be tracked and fixed under this bug.

Thanks

@ybyzek
Copy link
Contributor Author

ybyzek commented Mar 25, 2021

@saurabh-slacklife IMO this is up to you to define scope, either:

  1. Address the one specific warning mentioned in the title/description
  2. Remove ALL related warnings (in which case, you can update the title/description)

@saurabh-slacklife
Copy link
Contributor

@ybyzek Cool, I'll update the scope and make another commit tomorrow morning.

@mjsax
Copy link
Member

mjsax commented Mar 26, 2021

@saurabh-slacklife -- it's also ok we we do multiple smaller PRs -- easier to review and quicker to merge. So maybe just address the simple comment I left on the PR, and do a follow up PR for the other required changes. Thanks.

@saurabh-slacklife
Copy link
Contributor

@mjsax I'm also in favour of multiple PRs. Just made the commit with your review comments.

@saurabh-slacklife
Copy link
Contributor

@ybyzek I don't have the edit permission to update the title/description. If you can help to update the scope.

@mjsax For review. Just pushed another PR for the remaining changes.
Thanks.

@mjsax
Copy link
Member

mjsax commented Apr 21, 2021

What is the status of this ticket?

@saurabh-slacklife
Copy link
Contributor

This can be closed now, the # mentioned in description and in comments are were handled. I don't have permission to make any modifications.

@mjsax
Copy link
Member

mjsax commented Apr 21, 2021

Thanks for your help to fix this issue @saurabh-slacklife!

@mjsax mjsax closed this as completed Apr 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants