Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Build ESM artifacts with Node16 module resolution #887

Closed
timostamm opened this issue Oct 27, 2023 · 0 comments · Fixed by #1104
Closed

Build ESM artifacts with Node16 module resolution #887

timostamm opened this issue Oct 27, 2023 · 0 comments · Fixed by #1104
Labels
cleanup Cleanup tasks

Comments

@timostamm
Copy link
Member

We currently build ESM artifacts with module resolution "Node", which is the Node.js v10 resolution algorithm.

Protobuf-ES had an issue in the artifacts that would have been caught by using "Node16" module resolution: bufbuild/protobuf-es#586

To guard against such issues, we should switch to "Node16" module resolution for all packages in this repository.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
cleanup Cleanup tasks
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Build ESM artifacts with Node16 moduleResolution connectrpc/connect-es
1 participant
@timostamm