Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Question: Is there any reason to archive the Result CallAdapter before? #12

Closed
Goooler opened this issue Mar 1, 2024 · 3 comments
Closed

Comments

@Goooler
Copy link
Contributor

Goooler commented Mar 1, 2024

I see you archived https://github.com/connyduck/calladapter and migrated to this lib, is there any reason to do so?

Maybe we can mention deprecation in that lib and suggest users move to this.

@connyduck
Copy link
Owner

kotlin.Result is a value class and did not work correctly in all cases with the runtime tye checks required for retrofit, causing crashes.

I added a warning and a link to the new project to the old one.

@Goooler
Copy link
Contributor Author

Goooler commented Mar 1, 2024

Result support in Retrofit will be finished in square/retrofit#4018, it would be great if you can take a review.

@connyduck
Copy link
Owner

Oh Result support directly in retrofit would be way better than a custom adapter

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants