-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Split grpc to a separate package #4
Comments
@AkihiroSuda , if you can create the repo (assuming a seperate repo), I can help porting the gRPC code over. Maybe containerd/grpc-errs or something better named 😅 ? |
I don't think we have to split the repo |
+1 to what @AkihiroSuda said. Creating a new repo for the gprc errors would be too much. We can have a separate package for grpc errors in the same errdefs repo. |
Ah I mistook the intent. A seperate package would be compiled out if users did not need it. I can open a PR on this and get your feedback. |
Because a downstream project may not always want to depend on gRPC
The text was updated successfully, but these errors were encountered: