Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Split grpc to a separate package #4

Closed
AkihiroSuda opened this issue Jan 24, 2024 · 4 comments
Closed

Split grpc to a separate package #4

AkihiroSuda opened this issue Jan 24, 2024 · 4 comments

Comments

@AkihiroSuda
Copy link
Member

Because a downstream project may not always want to depend on gRPC

@austinvazquez
Copy link
Contributor

austinvazquez commented Feb 8, 2024

@AkihiroSuda , if you can create the repo (assuming a seperate repo), I can help porting the gRPC code over. Maybe containerd/grpc-errs or something better named 😅 ?

@AkihiroSuda
Copy link
Member Author

I don't think we have to split the repo

@akhilerm
Copy link
Member

akhilerm commented Feb 9, 2024

+1 to what @AkihiroSuda said. Creating a new repo for the gprc errors would be too much. We can have a separate package for grpc errors in the same errdefs repo.

@austinvazquez
Copy link
Contributor

Ah I mistook the intent. A seperate package would be compiled out if users did not need it. I can open a PR on this and get your feedback.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants