Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Entrypoint string specification and validation #237

Open
ipuustin opened this issue Aug 8, 2023 · 5 comments
Open

Entrypoint string specification and validation #237

ipuustin opened this issue Aug 8, 2023 · 5 comments
Labels
question Further information is requested

Comments

@ipuustin
Copy link
Contributor

ipuustin commented Aug 8, 2023

Right now the entrypoint strings are '#'-delimited (Wasm file and method): #102. In #219 there was some discussion about specifying this particular entrypoint string format and semantics well, so it would be documented for users and other projects could potentially support this.

In particular, we need to write validation code and tests. For example, #219 listed these test cases:

  1. foo#bar
  2. #bar
  3. foo#bar#bar
  4. foo
  5. #foo#bar
  6. foo#
  7. foo#bar; -- %
@jsturtevant
Copy link
Contributor

also related to #194

@utam0k
Copy link
Member

utam0k commented Aug 14, 2023

👍

@Mossaka
Copy link
Member

Mossaka commented Sep 5, 2023

More discussion happened here: https://cloud-native.slack.com/archives/C04LTPB6Z0V/p1693606484029809

@jsturtevant
Copy link
Contributor

Pulling out the relevant differences from the slack thread:

  • wasmtime shim expects entrypoint to be a main.wasm#foo or main.wat#foo
  • wasmedge , lunatic expect entrypoint to be main.wasm (I am not sure if .wat is supported)
  • wws shim expect a app binary. (e.g. hello.js)
  • slight and spin don't expect anything from entrypoint because they look for framework specific manifest files on root directory (e.g. spin.toml)

@ereslibre
Copy link

ereslibre commented Sep 19, 2023

wws shim expect a app binary. (e.g. hello.js)

wws behaves as slight and spin. It may use a specific manifest too (if present) and scans for functions defined at any level beneath the root directory, mapping that subpath at the appropriate place in the HTTP server.

@Mossaka Mossaka added the question Further information is requested label Jan 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
question Further information is requested
Projects
None yet
Development

No branches or pull requests

5 participants