Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Compat API: building a container with a custom Dockerfile started failing with #10550 #10663

Closed
riyad opened this issue Jun 11, 2021 · 2 comments
Labels
kind/bug Categorizes issue or PR as related to a bug. locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments.

Comments

@riyad
Copy link
Contributor

riyad commented Jun 11, 2021

Is this a BUG REPORT or FEATURE REQUEST? (leave only one on its own line)

/kind bug

Description

Trying to find regressions by exercising the APIv2 through docker-py's test suite (see #5386) I came across a regression.

Building a container with a custom Dockerfile started failing with #10550.

Steps to reproduce the issue:

cat > custom.dockerfile <<EOF
FROM busybox
EOF
  1. tar cf test.tar custom.dockerfile

  2. curl -sS --unix-socket /run/user/1000/podman/podman.sock -XPOST 'http://localhost/v1.40/build?dockerfile=custom.dockerfile' -H "Content-Type: application/tar" --data-binary '@test.tar'

Describe the results you received:

Run against commit 2970e35 the result is:

400 Bad Request
{"cause":"invalid character 'c' looking for beginning of value","message":"failed to parse query parameter 'dockerfile': \"custom.dockerfile\": invalid character 'c' looking for beginning of value","response":400}

Describe the results you expected:

Before #10550 (e.g. c75d62c) was merged the result was:

200 OK
{"stream":"STEP 1: FROM busybox\n"}
{"stream":"STEP 2: COMMIT\n"}
{"stream":"--\u003e d3cd072556c\n"}
{"stream":"d3cd072556c21c1f1940bd536675b97d7d419a2287d6bb3bd5044ea7466db788\n"}
{"stream":"Successfully built d3cd072556c2\n"}
@openshift-ci openshift-ci bot added the kind/bug Categorizes issue or PR as related to a bug. label Jun 11, 2021
@mheon
Copy link
Member

mheon commented Jun 11, 2021

Dupe of #10660?

@riyad
Copy link
Contributor Author

riyad commented Jun 11, 2021

Oh, indeed. 😅

@riyad riyad closed this as completed Jun 11, 2021
@github-actions github-actions bot added the locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments. label Sep 21, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 21, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
kind/bug Categorizes issue or PR as related to a bug. locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments.
Projects
None yet
Development

No branches or pull requests

2 participants