Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

integration tests: images_test: images with multiple tags: is a NOP #8171

Closed
edsantiago opened this issue Oct 28, 2020 · 3 comments
Closed
Labels
locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments. stale-issue

Comments

@edsantiago
Copy link
Member

Discovered during #8165, filing in case that doesn't merge.

The following lines are NOPs:

session.LineInOutputContainsTag("docker.io/library/alpine", "latest")
session.LineInOutputContainsTag("docker.io/library/busybox", "glibc")
session.LineInOutputContainsTag("foo", "a")
session.LineInOutputContainsTag("foo", "b")
session.LineInOutputContainsTag("foo", "c")
session.LineInOutputContainsTag("bar", "a")
session.LineInOutputContainsTag("bar", "b")

Adding Expect(...).To(BeTrue()) leads to a new failure: LineInOutputContainsTag() is itself broken, its map implementation is onedimensional and only tracks one tag: so in a case like the above, with foo:a, foo:b, and foo:c, only one of a/b/c will be preserved and the rest of the tests will (falsely) fail. I wrote one possible fix for it but there is almost certainly a better way to do it. I am filing this in hopes that someone can quickly dash off a cleaner more idiomatic fix. (And, again, so the issue doesn't get lost if we find a better alternative to #8165).

And hey, as long as someone's on this, could you also fix the misspelled LineInOuputStartsWith()?

@github-actions
Copy link

A friendly reminder that this issue had no activity for 30 days.

@rhatdan
Copy link
Member

rhatdan commented Dec 1, 2020

@edsantiago is this fixed other then LineInOuputStartsWith

@edsantiago
Copy link
Member Author

Oops! Yes, this was fixed in #8165, which did indeed merge. link to fix

@github-actions github-actions bot added the locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments. label Sep 22, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 22, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments. stale-issue
Projects
None yet
Development

No branches or pull requests

2 participants