Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add seccomp #25

Closed
JonathanBerhe opened this issue May 23, 2021 · 13 comments · Fixed by #292
Closed

Add seccomp #25

JonathanBerhe opened this issue May 23, 2021 · 13 comments · Fixed by #292
Assignees
Labels
enhancement New feature or request

Comments

@JonathanBerhe
Copy link

Hi, thanks for the project, it's very intresting!
I would like to work on seccomp feature if possible.

@flxo
Copy link

flxo commented May 23, 2021

@JonathanBerhe Just a note: @Inorik recently implemented some basic BPF stuff for something similar: https://github.com/esrlabs/northstar/blob/master/northstar/src/runtime/island/seccomp.rs Maybe this is helpful.

@utam0k
Copy link
Member

utam0k commented May 23, 2021

@JonathanBerhe
Of course! I welcome your challenge.
I assigned you for this issue.
If possible, it would be helpful if you could keep the following points in mind

  • Try not to make the build process too complicated or wrapped(e.g. using build.rs).
  • Minimize rework by breaking the implementation into tiny PRs.

@JonathanBerhe
Copy link
Author

@JonathanBerhe Just a note: @Inorik recently implemented some basic BPF stuff for something similar: https://github.com/esrlabs/northstar/blob/master/northstar/src/runtime/island/seccomp.rs Maybe this is helpful.

Many thanks for the input!

@flxo
Copy link

flxo commented May 25, 2021

  • Try not to make the build process too complicated or wrapped(e.g. using build.rs).

The crucial point is the mapping of syscall names to numbers. You have two options: A static to maintain list or the very very messy build.rs thing we do. If I would have to decide again I'd go for the list. Syscall number never change.

@utam0k
Copy link
Member

utam0k commented May 25, 2021

@flxo
Thanks for the advice! I too am wondering what to do in this area rather than implement.

@JonathanBerhe
Copy link
Author

@utam0k Hi, I'll show you the progress in the next days. I choose to map sys calls to the relative number of each architecture without a complex build system in build.rs

@utam0k
Copy link
Member

utam0k commented Jun 4, 2021

@JonathanBerhe Copy that. Thank you for keeping me informed of your progress. I'll look forward to it :)

@utam0k
Copy link
Member

utam0k commented Jul 3, 2021

@JonathanBerhe Hi! Do you have any problems about it? I don't want to rush you, but if there is anything I can do to help you, I would be happy.

@JonathanBerhe
Copy link
Author

JonathanBerhe commented Jul 5, 2021

@utam0k Hi, sorry for the late.
I was being pretty occupied with other projects. I'll open a PR asap this week with docs that describes the solution. 👍

@utam0k
Copy link
Member

utam0k commented Jul 6, 2021

@JonathanBerhe I understand. No problem at all. I was just wondering if I should wait for this or not since I'm thinking of doing the first release soon.

@JonathanBerhe
Copy link
Author

@utam0k I think that we need to spend some times on testing, since this is a security feature. If you think that we can release a first version without a seccomp implementation for me is ok

@utam0k
Copy link
Member

utam0k commented Aug 24, 2021

@JonathanBerhe Are you busy? Let me know if you find it difficult to find the time.

@JonathanBerhe
Copy link
Author

@utam0k Hi, I've opened a new PR in WIP. #235

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants