Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

All path rules require paths to be lowercase #851

Closed
stevenbower opened this issue Nov 16, 2016 · 2 comments
Closed

All path rules require paths to be lowercase #851

stevenbower opened this issue Nov 16, 2016 · 2 comments

Comments

@stevenbower
Copy link
Contributor

All of the path routing rules call types.CanonicalDomain which trims space and lowercases but this means that any paths you'd like to route by must all be in lowercase as well.

@stevenbower
Copy link
Contributor Author

Looks like this was broken as part of fixing #733

stevenbower added a commit to stevenbower/traefik that referenced this issue Nov 17, 2016
@stevenbower
Copy link
Contributor Author

This changes the behavior of "path" based rules such that they continue to trim the path strings in the rules but not lowercase them. Not doing this leads to inconsistent behavior where you can define a rule (eg PathPrefix:/fooBar) but that rule will not will match a path that is the same (eg http://foo.com/fooBar will not match this rule). An alternative approach would be to change the path matching such that it downcases the incomping path prior to comparison but that seems overly broad and I suspect (but maybe I'm wrong) that the behavior add in #733 for Path based rules was not intended.

emilevauge pushed a commit that referenced this issue Nov 17, 2016
emilevauge pushed a commit that referenced this issue Nov 17, 2016
@traefik traefik locked and limited conversation to collaborators Sep 1, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

2 participants