-
Notifications
You must be signed in to change notification settings - Fork 5.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
All path rules require paths to be lowercase #851
Comments
Looks like this was broken as part of fixing #733 |
This changes the behavior of "path" based rules such that they continue to trim the path strings in the rules but not lowercase them. Not doing this leads to inconsistent behavior where you can define a rule (eg PathPrefix:/fooBar) but that rule will not will match a path that is the same (eg http://foo.com/fooBar will not match this rule). An alternative approach would be to change the path matching such that it downcases the incomping path prior to comparison but that seems overly broad and I suspect (but maybe I'm wrong) that the behavior add in #733 for Path based rules was not intended. |
All of the path routing rules call types.CanonicalDomain which trims space and lowercases but this means that any paths you'd like to route by must all be in lowercase as well.
The text was updated successfully, but these errors were encountered: