Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't run go test on .glide cache folder #1057

Merged
merged 1 commit into from
Jan 23, 2017
Merged

Don't run go test on .glide cache folder #1057

merged 1 commit into from
Jan 23, 2017

Conversation

vdemeester
Copy link
Contributor

Because… you know… 🐻

Signed-off-by: Vincent Demeester vincent@sbr.pm

@vdemeester
Don't run go test on .glide cache folder
8c71a0f 
Signed-off-by: Vincent Demeester <vincent@sbr.pm>
emilevauge
emilevauge approved these changes Jan 23, 2017
View reviewed changes
Copy link
Member

@emilevauge emilevauge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@trecloux
Copy link
Contributor

LGTM 👍

@guilhem
Copy link
Contributor

guilhem commented Jan 23, 2017

👍 I had to do it in my PR c9ba156 👼

@vdemeester
Copy link
Contributor Author

@guilhem yep I saw 👼 🙇
Once you're PR is green and merged, I'll close this one 😝

@guilhem
Copy link
Contributor

guilhem commented Jan 23, 2017

@vdemeester you can merge this one, I will rebase :)

@vdemeester vdemeester merged commit 68bd24d into traefik:master Jan 23, 2017
@vdemeester vdemeester deleted the fix-unit-test-script branch January 23, 2017 14:43
@ldez ldez added this to the 1.2 milestone Oct 1, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@emilevauge emilevauge emilevauge approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
1.2
Development

Successfully merging this pull request may close these issues.
5 participants
@vdemeester @trecloux @guilhem @emilevauge @ldez