Minor Health UI fixes #1651
Merged
Minor Health UI fixes #1651
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- format the Oy axis ticks as integers on the Total Status Code Count chart - prevent the Average Response Time chart from showing negative values on the Oy axis - remove the deprecated transitionDuration field - set the transition duration to 0 on the Average Response Time chart to avoid triggering an NVD3 marker placement bug
ldez
added
status/3-needs-merge
and removed
status/2-needs-review
status/3-needs-merge
labels
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
transitionDurationfieldHere is some background on
transitionDuration: https://stackoverflow.com/questions/30455485/transitionduration-function-does-not-exist-in-nvd3-jsThese are some issues that I noticed while developing #1650 and I thought you guys might want to have them fixed. Please note that I'm not much of a web developer, so I hope I got them right :)