Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Oxy with fixes on websocket + integration tests #1905

Merged
merged 1 commit into from
Aug 1, 2017
Merged

Oxy with fixes on websocket + integration tests #1905

merged 1 commit into from
Aug 1, 2017

Conversation

juliens
Copy link
Member

@juliens juliens commented Jul 31, 2017

Upgrade oxy version with the oxy version with fix for origin problem
(403 on multiple websocket server)
Add integration tests

fixes #1900

@ldez ldez added this to the 1.3 milestone Jul 31, 2017
ldez
ldez approved these changes Jul 31, 2017
View reviewed changes
Copy link
Contributor

@ldez ldez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 💥

seriousben
seriousben approved these changes Jul 31, 2017
View reviewed changes
Copy link

@seriousben seriousben left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

errm
errm approved these changes Aug 1, 2017
View reviewed changes
Copy link
Contributor

@errm errm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

vdemeester
vdemeester approved these changes Aug 1, 2017
View reviewed changes
Copy link
Contributor

@vdemeester vdemeester left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🐮

@ldez ldez merged commit 1b4dc37 into traefik:v1.3 Aug 1, 2017
@ldez ldez mentioned this pull request Aug 1, 2017
Closed
@rawmind0 rawmind0 mentioned this pull request Aug 21, 2017
Closed
@juliens juliens deleted the fix-1900 branch September 13, 2017 13:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@seriousben seriousben seriousben approved these changes

@ldez ldez ldez approved these changes

@errm errm errm approved these changes

@vdemeester vdemeester vdemeester approved these changes

Assignees
No one assigned
Labels
area/websocket kind/bug/fix a bug fix priority/P0 needs hot fix
Projects
None yet
Milestone
1.3
Development

Successfully merging this pull request may close these issues.
5 participants
@juliens @vdemeester @errm @ldez @seriousben