Hide the pflag error when displaying help. #2800
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
timoreimann
reviewed
Feb 3, 2018
| @@ -28,6 +28,7 @@ import ( | |||
| "github.com/containous/traefik/types" | |||
| "github.com/containous/traefik/version" | |||
| "github.com/coreos/go-systemd/daemon" | |||
| "github.com/ogier/pflag" | |||
There was a problem hiding this comment.
FWIW, most people use spf13/pflag instead of ogier's.
There was a problem hiding this comment.
There was a problem hiding this comment.
All good then, thanks. 👍
timoreimann
approved these changes
Feb 3, 2018
traefiker
force-pushed
the
fix/hide-pflag-help-error
branch
from
4181368
to
285d6d2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Hide the pflag error when displaying help.
Motivation
Better help display.