Clarify how setting a frontend priority works #2818
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ldez
added
area/documentation
status/2-needs-review
bot/no-merge
and removed
status/0-needs-triage
labels
nmengin
approved these changes
Feb 7, 2018
|
Thanks for the fast processing! I'd like to reiterate: I would be amazing to have a way to get the previously documented behavior, i.e. comparing priorities first, only using rule lengths to break ties. Would someone like to pick up on that? |
See traefik#1962 for discussion, and https://github.com/containous/traefik/blob/c0563f1a395d53edbbf1030b2387435077eeb871/server/server.go#L1338-L1347 for the relevant code.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Clarify how setting a frontend priority works.
See #1962 for discussion, and https://github.com/containous/traefik/blob/c0563f1a395d53edbbf1030b2387435077eeb871/server/server.go#L1338-L1347 for the now documented code.
Motivation
I set the priority on a rule, and it wasn't effective the way I understood it from the documentation. This gave us trouble in routing in our test environment.
Reading #1962, I realized from the code snippet that setting the priority works more like an offset than an absolute ordering of frontends.
More
Purely a documentation change.
Additional Notes
I would be amazing to have a way to get the previously documented behavior, i.e. comparing priorities first, only using rule lengths to break ties.