Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change port of traefik for error pages integration test #2907

Merged
merged 1 commit into from
Feb 23, 2018
Merged

Change port of traefik for error pages integration test #2907

merged 1 commit into from
Feb 23, 2018

Conversation

mmatur
Copy link
Member

@mmatur mmatur commented Feb 21, 2018

What does this PR do?

This PR change Træfik port in error page integration test

Motivation

Be able to run integration test with Goland without to be sudo

More

  • Added/updated tests

@mmatur mmatur added kind/enhancement a new or improved feature. status/2-needs-review labels Feb 21, 2018
@mmatur mmatur added this to the 1.6 milestone Feb 21, 2018
@mmatur mmatur changed the title Change port of traefik for error pages integration Change port of traefik for error pages integration test Feb 21, 2018
ldez
ldez approved these changes Feb 21, 2018
View reviewed changes
Copy link
Contributor

@ldez ldez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but not ♻️

nmengin
nmengin approved these changes Feb 22, 2018
View reviewed changes
Copy link
Contributor

@nmengin nmengin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

juliens
juliens approved these changes Feb 23, 2018
View reviewed changes
Copy link
Member

@juliens juliens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@traefiker traefiker merged commit e28ebf1 into traefik:master Feb 23, 2018
@mmatur mmatur deleted the feature/port-error-pages branch March 21, 2018 17:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nmengin nmengin nmengin approved these changes

@ldez ldez ldez approved these changes

@juliens juliens juliens approved these changes

Assignees
No one assigned
Labels
area/middleware kind/enhancement a new or improved feature. size/S
Projects
None yet
Milestone
1.6
Development

Successfully merging this pull request may close these issues.
5 participants
@mmatur @juliens @ldez @nmengin @traefiker