Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Frontend rule and segment labels. #3091

Merged
merged 2 commits into from
Mar 28, 2018
Merged

Frontend rule and segment labels. #3091

merged 2 commits into from
Mar 28, 2018

Conversation

ldez
Copy link
Contributor

@ldez ldez commented Mar 27, 2018 •
edited
Loading

What does this PR do?

Fixes frontend rule and segment labels.

Motivation

Fixes #3089, #3094

More

  • Added/updated tests

@ldez ldez requested a review from a team as a code owner March 27, 2018 18:17
@traefiker traefiker added this to the 1.6 milestone Mar 27, 2018
juliens
juliens approved these changes Mar 28, 2018
View reviewed changes
Copy link
Member

@juliens juliens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

mmatur
mmatur approved these changes Mar 28, 2018
View reviewed changes
Copy link
Member

@mmatur mmatur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ldez ldez requested a review from a team as a code owner March 28, 2018 13:59
nmengin
nmengin approved these changes Mar 28, 2018
View reviewed changes
Copy link
Contributor

@nmengin nmengin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@traefiker traefiker merged commit a731b43 into traefik:v1.6 Mar 28, 2018
This was referenced Mar 28, 2018
Closed
Closed
@ldez ldez deleted the fix/rancher-segment branch March 28, 2018 21:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@traefiker traefiker traefiker approved these changes

@nmengin nmengin nmengin approved these changes

@mmatur mmatur mmatur approved these changes

@juliens juliens juliens approved these changes

Assignees
No one assigned
Labels
area/provider/docker area/provider/rancher kind/bug/fix a bug fix size/S
Projects
None yet
Milestone
1.6
Development

Successfully merging this pull request may close these issues.
5 participants
@ldez @juliens @mmatur @nmengin @traefiker