Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Several apps with same backend name in Marathon. #3109

Merged
merged 1 commit into from
Apr 4, 2018

Conversation

ldez
Copy link
Contributor

@ldez ldez commented Mar 30, 2018

What does this PR do?

Several apps with same backend name in Marathon.

Motivation

Fixes #2709

More

  • Added/updated tests

@ldez ldez requested a review from a team as a code owner March 30, 2018 17:17
@traefiker traefiker added this to the 1.6 milestone Mar 30, 2018
@ldez ldez force-pushed the fix/marathon-same-backend branch 4 times, most recently from e8450c2 to 5932f16 Compare March 31, 2018 01:27
Copy link
Member

@juliens juliens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ldez ldez force-pushed the fix/marathon-same-backend branch from 5932f16 to 321a18d Compare April 3, 2018 08:50
Copy link
Member

@mmatur mmatur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👏
One minor review ;)

servers[name] = *server
}

for _, app1 := range app.LinkedApps {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you please rename app1

Copy link
Contributor

@nmengin nmengin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants