-
Notifications
You must be signed in to change notification settings - Fork 5.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Reflect changes in catalog healthy nodes in healthCheck watch #3390
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mmatur
added
status/2-needs-review
kind/bug/fix
a bug fix
and removed
status/0-needs-triage
labels
May 25, 2018
mmatur
force-pushed
the
consulcatalog-issues
branch
from
May 25, 2018 17:57
445ecfa
to
df294e7
Compare
2 tasks
mmatur
changed the title
reflect changes in catalog healthy nodes in healthCheck watch
Reflect changes in catalog healthy nodes in healthCheck watch
May 29, 2018
mmatur
approved these changes
May 30, 2018
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👏
ldez
approved these changes
Jun 4, 2018
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
juliens
approved these changes
Jun 5, 2018
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
traefiker
force-pushed
the
consulcatalog-issues
branch
from
June 5, 2018 06:26
b80e73f
to
080003d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Resolve issue that "Traefik does not refresh backend list on state change of consul catalog health checks"
Motivation
The list of backends were not being reflected in Traefik with changes in health checks of nodes.
Fixes #3380
Related to #3157
More