Enclose IPv6 addresses in "[]" #3477
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ldez
changed the title
ldez
added
status/2-needs-review
kind/bug/fix
|
Do you want me to add a test with a config that contains an IPv6 backend to ensure the configuration is consistent ? |
ldez
added
area/provider/consulcatalog
and removed
area/provider/consul
bot/no-merge
labels
|
Thanks for the contribution 👍 I rebased your PR on 1.6 branch. Could you add tests on |
|
@herver you don't need to merge with v1.6 (unless you have conflicts), we have a bot to do it at the end of the review process |
The test generates a catalog update containing a dummy service that has two backends: - one IPv4 - one IPv6 We ensure that both of the backend URLs are correctly formatted (as generated by getServer())
|
@ldez Oh ok :) well I added the test (which might be a bit overkill) but it makes sure that both v4 and v6 backend URLs are generated properly |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Add square brackets
[and]when dealing with IPv6 backends.Motivation
I was just bitten by #714 which I can confirm, and I'm running a version with this PR in production just fine.
Fixes #714