-
Notifications
You must be signed in to change notification settings - Fork 5.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Change syntax in quick start guide #3726
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
traefiker
added
area/acme
area/logs
area/middleware
area/provider/consul
area/provider/consulcatalog
area/provider/docker
area/provider/ecs
area/provider/eureka
area/provider/k8s/ingress
area/provider/marathon
area/provider/mesos
area/provider/rancher
area/webui
size/L
status/0-needs-triage
labels
Aug 4, 2018
ldez
added
area/documentation
status/2-needs-review
kind/bug/fix
a bug fix
and removed
area/acme
area/logs
area/middleware
area/provider/consul
area/provider/consulcatalog
area/provider/docker
labels
Aug 4, 2018
ldez
changed the title
Changs syntax in quick start guide
Change syntax in quick start guide
Aug 4, 2018
LGTM Thanks for this contribution! |
vdemeester
approved these changes
Aug 4, 2018
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🐯
ldez
approved these changes
Aug 4, 2018
nmengin
approved these changes
Aug 5, 2018
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Many tahnks for this correction @trotro 👍 👏 📖
LGTM
Docker compose scale command syntax correction
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Correction of the syntax of docker-compose command
Motivation
Allow new users to follow successfully the quick start guide.
More
Additional Notes
Related to #3677