-
Notifications
You must be signed in to change notification settings - Fork 5.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added two examples with labels in docker-compose.yml #3891
Conversation
Maybe add a small notice regarding Nice PR otherwise. Been missing such section a long time. 👍 |
I don't know what to say regarding the |
I'll look into maybe writing some text. I think the official documentation have some great stuff though. Source: https://docs.docker.com/compose/compose-file/#variable-substitution |
Thanks, I'll add a note about it. Need to run this morning! |
@pascalandy could you rebase on v1.7 and change the base branch of the PR to v1.7 (edit button on the top of the PR) |
Add more details and switched to branch 1.7 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hello @pascalandy ,
thanks a lot for your time on this proposal.
Great work!
I've put a few language (minor) reviews to fix.
Also, would it be possible to create a new User Guide's page named "Using Labels with Docker-Compose"?
Because this content deserves a dedicated page, instead of being lost on the bottom of the "Examples" pages.
If you need help on doing this, do not hesitate to ping me on the community's Slack at https://slack.traefik.io/ : I will happily allocate some time with you to work on this.
Thanks again!
I agree!
Let's start by merging this first :) |
Hello @pascalandy , after a discussion with other maintainers, it sounds like that instead of a very specific example in the user guide section (which is already "complicated"), We fear the maintenance effort of a full Is there another intent in this user guide you wanted to underline (a use case)? If, could you details the intent? |
The use case was from months of conversation on #563 (comment). The regex ability is a powerful one. Maybe I could only showcase the labels and not the whole docker-compose file. I personally prefer a full blast example :) |
Hello @pascalandy , my apologies for the delay of response. Thanks for this contribution. It is LGTM. We might want to rework example section later, but right now it is ok. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@@ -371,7 +371,9 @@ deploy: | |||
|
|||
Something more tricky using `regex`. | |||
|
|||
In this case a slash is added to `siteexample.io/portainer` and redirect to `siteexample.io/portainer/`. For more details: https://github.com/containous/traefik/issues/563 | |||
In this case a slash is added to `siteexample.io/portainer` and redirect to `siteexample.io/portainer/`. For more details: https://github.com/containous/traefik/issues/563 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should this not be redirected
instead?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
correct redirected
What does this PR do?
Doc: Added two example / Using labels in docker-compose.yml
Motivation
#563 (comment)
More
null
Additional Notes
#563 (comment)