Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

frame-deny should be set to true to enable the header #4171

Merged
merged 2 commits into from
Nov 14, 2018
Merged

frame-deny should be set to true to enable the header #4171

merged 2 commits into from
Nov 14, 2018

Conversation

swestcott
Copy link
Contributor

ingress.kubernetes.io/frame-deny should be set to true to send X-Frame-Options: DENY

@swestcott swestcott requested a review from a team as a code owner November 7, 2018 20:15
@ldez ldez changed the base branch from master to v1.7 November 8, 2018 07:20
@ldez ldez added this to the 1.7 milestone Nov 8, 2018
nmengin
nmengin approved these changes Nov 13, 2018
View reviewed changes
Copy link
Contributor

@nmengin nmengin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 📖

dtomcej
dtomcej approved these changes Nov 14, 2018
View reviewed changes
Copy link
Contributor

@dtomcej dtomcej left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
:shipit:

@traefiker traefiker merged commit df688db into traefik:v1.7 Nov 14, 2018
@ldez ldez mentioned this pull request Nov 19, 2018
Merged
17 tasks
@ldez ldez mentioned this pull request Dec 5, 2018
Merged
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dtomcej dtomcej dtomcej approved these changes

@nmengin nmengin nmengin approved these changes

@mmatur mmatur mmatur approved these changes

Assignees
No one assigned
Labels
area/documentation area/provider/k8s/ingress size/S
Projects
None yet
Milestone
1.7
Development

Successfully merging this pull request may close these issues.
6 participants
@swestcott @mmatur @nmengin @dtomcej @ldez @traefiker