Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Verify ctx when we send configuration message in docker provider #4185

Merged
merged 1 commit into from
Nov 12, 2018
Merged

Verify ctx when we send configuration message in docker provider #4185

merged 1 commit into from
Nov 12, 2018

Conversation

juliens
Copy link
Member

@juliens juliens commented Nov 10, 2018

What does this PR do?

Add a select when we want to send configuration message to be sure the ctx is not done

Motivation

Fix a goroutine leak that can stuck the provider shutdown

@juliens juliens requested a review from a team as a code owner November 10, 2018 08:53
@traefiker traefiker added this to the 1.7 milestone Nov 10, 2018
ldez
ldez approved these changes Nov 10, 2018
View reviewed changes
Copy link
Contributor

@ldez ldez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

nmengin
nmengin approved these changes Nov 12, 2018
View reviewed changes
Copy link
Contributor

@nmengin nmengin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

mmatur
mmatur approved these changes Nov 12, 2018
View reviewed changes
Copy link
Member

@mmatur mmatur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@traefiker traefiker merged commit 9b0586c into traefik:v1.7 Nov 12, 2018
@ldez ldez mentioned this pull request Nov 19, 2018
Merged
17 tasks
@juliens juliens deleted the fix-docker-provider branch September 6, 2019 05:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nmengin nmengin nmengin approved these changes

@ldez ldez ldez approved these changes

@mmatur mmatur mmatur approved these changes

Assignees
No one assigned
Labels
area/provider/docker kind/bug/fix a bug fix size/S
Projects
None yet
Milestone
1.7
Development

Successfully merging this pull request may close these issues.
5 participants
@juliens @mmatur @ldez @nmengin @traefiker