Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clarify swarm loadbalancer documentation #4194

Merged

Conversation

jlevesy
Copy link
Contributor

@jlevesy jlevesy commented Nov 13, 2018

What does this PR do?

Add a note which clarifies Traefik's behaviour when the traefik.backend.loadbalancer.swarm=true label is set on a backend.

Motivation

Traefik's behaviour in that case caused some misunderstanding (see #4179 and #2138).
Here's a proposal to improve the documentation.

WDYT folks ?

docs/configuration/backends/docker.md Outdated Show resolved Hide resolved
@jlevesy jlevesy force-pushed the clarify-swarm-loadbalancer-documentation branch from fb8f8dd to 83906e1 Compare November 13, 2018 18:38
@mmatur mmatur added this to the 1.7 milestone Nov 14, 2018
@jlevesy jlevesy force-pushed the clarify-swarm-loadbalancer-documentation branch 2 times, most recently from b1d4171 to 265e6eb Compare November 14, 2018 16:46
@jlevesy jlevesy requested a review from a team as a code owner November 14, 2018 16:46
@jlevesy jlevesy changed the base branch from master to v1.7 November 14, 2018 16:46
Copy link
Contributor

@ldez ldez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@geraldcroes geraldcroes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kachkaev
Copy link
Contributor

Thank you for adding this note @jlevesy! It finally explains why I could not configure sticky sessions for one of my projects that uses docker swarm :-D

@jlevesy jlevesy force-pushed the clarify-swarm-loadbalancer-documentation branch from 265e6eb to e1731d9 Compare November 15, 2018 16:34
Copy link
Member

@mmatur mmatur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants