Support external name service on global default backend #4564
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
geraldcroes
added
status/1-needs-design-review
kind/enhancement
|
Bump! Any feedback on this PR? Thanks for your attention. |
|
I approve the design of this PR. @kippandrew is correct this is intended behavior. |
ldez
added
status/1-needs-design-review
status/2-needs-review
and removed
status/2-needs-review
status/1-needs-design-review
labels
|
Bump. Any possibility someone can take a look at this? Thanks! |
ldez
added
kind/bug/fix
traefiker
added
bot/merge-retry-1
status/4-merge-in-progress
and removed
bot/merge-retry-1
labels
traefiker
force-pushed
the
v1.7-kubernetes-default-backend-external-name
branch
from
7c08af2
to
154dfc9
Compare
16 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR adds support for global backends pointing to an ExternalName services. This is accomplished by checking the service type when adding the global default backend. If the service type is an ExternalName service, the backend is mapped to the ExternalName service's url. This is basically a copy paste of what is done with normal backends.
Motivation
It would be useful in my environment (and others I'm sure) for the Kubernetes provider to support a global default backend that's points to an ExternalName service. This is already supported for regular backends so I imagine not supporting it here was an oversight.
More
Additional Notes
None