Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enhance manual dnsChallenge documentation #4636

Merged
merged 4 commits into from
Mar 27, 2019
Merged

Enhance manual dnsChallenge documentation #4636

merged 4 commits into from
Mar 27, 2019

Conversation

ntaranov
Copy link
Contributor

What does this PR do?

Updates documentation as discussed with @dduportal
Makes it more clear that manual dnsChallenge provider requires image to be run with docker run -it and that it isn't going to work with just docker stack deploy

Motivation

Save others from stumbling upon this
#4626

More

  • Added/updated tests
  • [v] Added/updated documentation

@ldez ldez changed the base branch from master to v2.0 March 19, 2019 20:49
ldez
ldez suggested changes Mar 19, 2019
View reviewed changes
Copy link
Contributor

@ldez ldez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👀

docs/content/https-tls/acme.md Outdated Show resolved Hide resolved
docs/content/https-tls/acme.md Outdated Show resolved Hide resolved
@ldez ldez added this to the 2.0 milestone Mar 20, 2019
@ntaranov
Copy link
Contributor Author

Ready for push if the text is alright.

@ntaranov

This comment has been minimized.

Sign in to view
ldez
ldez approved these changes Mar 23, 2019
View reviewed changes
Copy link
Contributor

@ldez ldez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ntaranov
Clarify that manual dnsChallenge provider works only when run as dock…
23ab6a6 
…er run -it

Make it more clear that manual dnsChallenge provider requires image to be run with docker run -it and that it isn't going to work with just docker stack deploy
@ntaranov
Leave provider-specific text only in the footnote
051bb4a 
Also delete the detailed workaround description
@ldez ldez self-requested a review March 27, 2019 09:53
ldez
ldez approved these changes Mar 27, 2019
View reviewed changes
Copy link
Contributor

@ldez ldez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ldez ldez added the kind/enhancement a new or improved feature. label Mar 27, 2019
juliens
juliens approved these changes Mar 27, 2019
View reviewed changes
Copy link
Member

@juliens juliens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

geraldcroes
geraldcroes approved these changes Mar 27, 2019
View reviewed changes
Copy link
Contributor

@geraldcroes geraldcroes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎈 LGTM 🎈

@traefiker traefiker merged commit 7932e31 into traefik:v2.0 Mar 27, 2019
@ldez ldez changed the title Clarify that manual dnsChallenge provider works only when run as docker run -it Clarify manual dnsChallenge Mar 27, 2019
@ldez ldez changed the title Clarify manual dnsChallenge Enhance manual dnsChallenge documentation Mar 27, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ldez ldez ldez approved these changes

@geraldcroes geraldcroes geraldcroes approved these changes

@juliens juliens juliens approved these changes

Assignees
No one assigned
Labels
area/acme area/documentation kind/enhancement a new or improved feature. size/S
Projects
None yet
Milestone
2.0
Development

Successfully merging this pull request may close these issues.
5 participants
@ntaranov @juliens @geraldcroes @ldez @traefiker