Fix spamming events in listenProviders #477
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
if you push a test build of this to docker hub i'd be happy to start using it and let you know how it goes |
|
Here we go |
|
Please don't merge this one before validation from @nlf |
emilevauge
force-pushed
the
fix-spamming-events
branch
from
a76159b
to
1ddecbb
Compare
|
this is looking good 👍 ran it all day yesterday, which included destroying and launching a total of about 45 containers, and it caught all the updates without issue |
emilevauge
force-pushed
the
fix-spamming-events
branch
from
6fa4635
to
60a1b49
Compare
Signed-off-by: Emile Vauge <emile@vauge.com>
Signed-off-by: Emile Vauge <emile@vauge.com>
Signed-off-by: Emile Vauge <emile@vauge.com>
Signed-off-by: Emile Vauge <emile@vauge.com>
emilevauge
force-pushed
the
fix-spamming-events
branch
from
60a1b49
to
15e04bb
Compare
|
LGTM 🐹 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes spamming events from providers (mostly for k8s).
Moves the
deepEqualscheck fromlistenConfigurationstolistenProviders, before the Providers Throttle check.Fixes #448
Fixes #449
Also fixes some other issues:
Fixes #453
Fixes #243
Fixes #475
Signed-off-by: Emile Vauge emile@vauge.com