Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

file parser: skip nil value. #7058

Merged
merged 1 commit into from
Jul 17, 2020
Merged

file parser: skip nil value. #7058

merged 1 commit into from
Jul 17, 2020

Conversation

ldez
Copy link
Contributor

@ldez ldez commented Jul 16, 2020

What does this PR do?

file parser: skip nil value.

Motivation

allow to manage pointer of bool.

More

  • Added/updated tests
  • Added/updated documentation

@ldez ldez added this to the 2.3 milestone Jul 16, 2020
rtribotte
rtribotte approved these changes Jul 17, 2020
View reviewed changes
Copy link
Member

@rtribotte rtribotte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

jbdoumenjou
jbdoumenjou approved these changes Jul 17, 2020
View reviewed changes
Copy link
Member

@jbdoumenjou jbdoumenjou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

mmatur
mmatur approved these changes Jul 17, 2020
View reviewed changes
Copy link
Member

@mmatur mmatur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@traefiker traefiker merged commit 44a244b into traefik:v2.3 Jul 17, 2020
@ldez ldez deleted the fix/file-parser-nil branch July 17, 2020 10:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rtribotte rtribotte rtribotte approved these changes

@mmatur mmatur mmatur approved these changes

@jbdoumenjou jbdoumenjou jbdoumenjou approved these changes

Assignees
No one assigned
Labels
area/provider kind/bug/fix a bug fix size/S
Projects
None yet
Milestone
2.3
Development

Successfully merging this pull request may close these issues.
5 participants
@ldez @jbdoumenjou @mmatur @rtribotte @traefiker