Add support for docker healthcheck 👼 #708
Conversation
vdemeester
force-pushed
the
docker-support-healthcheck
branch
2 times, most recently
from
3b6f439
to
5530915
Compare
vdemeester
changed the title
| @@ -214,6 +215,9 @@ func (provider *Docker) Provide(configurationChan chan<- types.ConfigMessage, po | |||
| } | |||
| eventHandler.Handle("start", startStopHandle) | |||
| eventHandler.Handle("die", startStopHandle) | |||
| eventHandler.Handle("health_status: healthy", startStopHandle) | |||
There was a problem hiding this comment.
The way health_status event are sent via the docker api is a little buggy, see moby/moby#25800 👼
| @@ -378,6 +382,10 @@ func (provider *Docker) containerFilter(container dockerData) bool { | |||
| return false | |||
| } | |||
|
|
|||
| if container.Health != "" && container.Health != "healthy" { | |||
| return false | |||
There was a problem hiding this comment.
I would add a debug log here to inform why the container has been filtered ;)
|
Tested, it works nicely, thanks! 💯
|
- React to health_status events - Filter container that have a health status *and* that are not healthy Signed-off-by: Vincent Demeester <vincent@sbr.pm>
vdemeester
force-pushed
the
docker-support-healthcheck
branch
from
5530915
to
d68389d
Compare
|
Fixes #666 |
ldez
added
status/3-needs-merge
and removed
status/2-needs-review
status/1-needs-design-review
labels
This add the simplest support for
HEALTHCHECKfor the docker provider.Fixes #666.
It works like the other provider that support healthchecks (marathon for example) — if healthcheck are not supported, then it work as usual and if a container supports it, it filters the container if it's not healthy.
Update documentation(it's actually not documented on other providers, so…)Add integration tests(too much extra work on that, I need to update libkermit and add support for atestRequirethingy with a check on docker >= 1.12 — will do in a follow up)/cc @containous/traefik
🐸
Signed-off-by: Vincent Demeester vincent@sbr.pm