-
Notifications
You must be signed in to change notification settings - Fork 5.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use first port by default #782
Conversation
If no information is given, use first index of ports
@guilhem I'm not sure I understand your code ^^ |
@emilevauge indeed, I just change filter who was removing this "supported" case. |
Oh indeed ;) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @guilhem
LGTM!
/cc @containous/traefik
@guilhem @emilevauge question though, should we do that for other providers ? (like the |
anything is ok for me. :) |
Maybe yes, we should stay consistent. |
@emilevauge hum, should we do that for docker and other providers for 1.1 then ? 👼 |
@emilevauge @vdemeester done in latest commit. to be used or not |
@guilhem thanks for those additions :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🐸
This feature use first port (PORT0) by default when there is multiple of ports