Complete object graph and unique'ify all objects #108
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
August 8, 2017 13:19
Modify `Modellable` protocols to resolve relationships in seperate method
loudmouth
force-pushed
the
improvement/modellable
branch
2 times, most recently
from
dc58f1e
to
6819c08
Compare
loudmouth
force-pushed
the
improvement/modellable
branch
from
15e6d5d
to
1c79dfc
Compare
Sources/Client+Modellable.swift
Outdated
| Fetch a collection of Entries from Contentful matching the specified query. | ||
|
|
||
| - Parameter query: The Query object to match results againts. | ||
| - Returns: An Observable forr the resulting `MappedContent` container. |
Sources/Client+Modellable.swift
Outdated
|
|
||
| /** | ||
| Fetches all entries and includes matching the passed in `Query`. The completion handler returned will return a `MappedContent` object which | ||
| contains an array of `Asset`s and a dictionary of ContentTypeId's to arrays of `EntryModellable` types of your own defining. |
There was a problem hiding this comment.
defining vs definition.
Sources/ContentModellable.swift
Outdated
| /** | ||
| Initializes a new `ContentModel` instance. | ||
|
|
||
| - Parameter entryTypes: References to the the types of your own defition, conforming to `EntryModellable`, which |
There was a problem hiding this comment.
defition vs definition
| // A type used to cache relationships that should be deleted in the `resolveRelationships()` method. | ||
| fileprivate struct DeletedRelationship {} | ||
|
|
||
| // Returns a dictionary representing the fields names and the target id(s) to create links to. |
There was a problem hiding this comment.
fields names or should it be field names?
Sources/DataCache.swift
Outdated
| } | ||
|
|
||
| public static func cacheKey(for resource: LocalizableResource) -> String { | ||
| let delimeter = "_" |
There was a problem hiding this comment.
hmm, I am seeing double here. Do you mind using the let constant of the DataCache here?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #107