-
Notifications
You must be signed in to change notification settings - Fork 81
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Introduce new properties for the Avatar component [HOMER-2119] #2519
Conversation
- showColorBorders - isPrimary
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
size-limit report 📦
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall this looks good.
- The loading skeleton seems to have broken: https://forma-36-git-feat-homer-2119.colorfuldemo.com/components/avatar#loading-skeleton
- I don't see any differences between active an inactive: https://forma-36-git-feat-homer-2119.colorfuldemo.com/components/avatar#isactive
@denkristoffer Hi Kristoffer, thanks for the review, I just addressed all the comments |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, looks good to me! One thing to note is that releases are not automated with alpha versions so I will do it manually later.
Purpose of PR
This PR adds the following new properties to the
Avatar
component:And replace enums for sizes and variants with simple string types
PR Checklist
readme.md
file(s)