Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Introduce new properties for the Avatar component [HOMER-2119] #2519

Merged
merged 11 commits into from
Jul 5, 2023

Conversation

miguelcrespo
Copy link
Contributor

Purpose of PR

This PR adds the following new properties to the Avatar component:

  • showColorBorders
  • isPrimary
  • isActive
  • icon

And replace enums for sizes and variants with simple string types

image

PR Checklist

  • I have read the relevant readme.md file(s)
  • All commits follow our Git commit message convention
  • Tests are added/updated/not required
  • Tests are passing
  • Storybook stories are added/updated/not required
  • Usage notes are added/updated/not required
  • Has been tested based on Contentful's browser support
  • Doesn't contain any sensitive information

@miguelcrespo miguelcrespo requested review from a team and Lelith as code owners July 4, 2023 13:45
@changeset-bot
Copy link

changeset-bot bot commented Jul 4, 2023

⚠️ No Changeset found

Latest commit: 6379ee4

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@vercel
Copy link

vercel bot commented Jul 4, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
forma-36 ✅ Ready (Inspect) Visit Preview Jul 5, 2023 0:05am

@github-actions
Copy link

github-actions bot commented Jul 4, 2023

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
CommonJS 147.83 KB (0%) 3 s (0%) 507 ms (+43.15% 🔺) 3.5 s
Module 144.08 KB (0%) 2.9 s (0%) 568 ms (+88.44% 🔺) 3.5 s

Copy link
Collaborator

@Lelith Lelith left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

packages/components/avatar/README.mdx Outdated Show resolved Hide resolved
packages/components/avatar/README.mdx Outdated Show resolved Hide resolved
Copy link
Collaborator

@denkristoffer denkristoffer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall this looks good.

packages/components/avatar/README.mdx Outdated Show resolved Hide resolved
packages/components/avatar/src/Avatar.tsx Outdated Show resolved Hide resolved
@miguelcrespo
Copy link
Contributor Author

@denkristoffer Hi Kristoffer, thanks for the review, I just addressed all the comments

Copy link
Collaborator

@denkristoffer denkristoffer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, looks good to me! One thing to note is that releases are not automated with alpha versions so I will do it manually later.

packages/components/avatar/README.mdx Outdated Show resolved Hide resolved
@miguelcrespo miguelcrespo merged commit 8b52c75 into main Jul 5, 2023
3 checks passed
@miguelcrespo miguelcrespo deleted the feat/homer-2119 branch July 5, 2023 13:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants