Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: avatar flickering #2553

Merged
merged 4 commits into from
Aug 9, 2023
Merged

fix: avatar flickering #2553

merged 4 commits into from
Aug 9, 2023

Conversation

jfctfl
Copy link
Contributor

@jfctfl jfctfl commented Aug 9, 2023

Purpose of PR

Fixes remounting of internal nodes on every render of the Avatar component

PR Checklist

  • I have read the relevant readme.md file(s)
  • All commits follow our Git commit message convention
  • Tests are added/updated/not required
  • Tests are passing
  • Storybook stories are added/updated/not required
  • Usage notes are added/updated/not required
  • Has been tested based on Contentful's browser support
  • Doesn't contain any sensitive information

…' into fix/HOMER-2241_avatar_flickering

# Conflicts:
#	packages/components/avatar/src/Avatar/Avatar.tsx
@jfctfl jfctfl requested review from Lelith and a team as code owners August 9, 2023 06:38
@jfctfl jfctfl requested review from bgutsol and giotiskl August 9, 2023 06:38
@changeset-bot
Copy link

changeset-bot bot commented Aug 9, 2023

🦋 Changeset detected

Latest commit: 4d22cf8

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 0 packages

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@vercel
Copy link

vercel bot commented Aug 9, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
forma-36 ✅ Ready (Inspect) Visit Preview Aug 9, 2023 8:32am

@github-actions
Copy link

github-actions bot commented Aug 9, 2023

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
CommonJS 129.42 KB (0%) 2.6 s (0%) 50 ms (+57.68% 🔺) 2.7 s
Module 125.88 KB (0%) 2.6 s (0%) 58 ms (+89.67% 🔺) 2.6 s

Copy link
Contributor

@ronaldronson ronaldronson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wow, something new I learned

@jfctfl jfctfl merged commit aa385c0 into main Aug 9, 2023
3 checks passed
@jfctfl jfctfl deleted the fix/HOMER-2241_avatar_flickering branch August 9, 2023 08:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants