-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Path -> URI #3247
Merged
Merged
Path -> URI #3247
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for continuedev canceled.
|
Patrick-Erichsen
force-pushed
the
dallin/path-uri-v2
branch
from
December 17, 2024 19:51
647be11
to
9116818
Compare
…ontinue into dallin/path-uri-v2
…allin/path-uri-v2
This was referenced Dec 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is to fix path issues from trying to use paths instead of URIs when working with workspace files.
Goals:
Approach
Thoughts
activate
generates a.continuerc.json
to fix possibility of inifinite index looping. Jetbrains doesn't seem to have this fix. Same withconfig.ts
- generated on start in vscode but not jetbrainsSecretStorage
may have issues with remote? not sure, didn't changeGreptileContextProvider
is written to use local files, and will not work with SSH. I did not fix on this branch because it's a bit involved