sidebar will always reopen with cmd+L or Open chat #3377
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
fixes #3367. The sidebar will now alway open regardless of the last page that it was on.
changing the continueFocusInput command to be more like the navigateTo command may be worth considering, as using cmd+L or open chat quick pick won't take you to the chat page of the sidebar if you're currently on the history page or the more page. This fix works and doesn't have any side effects that I know of, and is important due to #3360 closing the sidebar more frequently.
this code (extensions/vscode/src/commands.ts:475) seems to just stop the process if any page other than the chat page is open.
Testing
tested on vscode