Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sidebar will always reopen with cmd+L or Open chat #3377

Merged
merged 1 commit into from
Dec 15, 2024

Conversation

HD787
Copy link
Contributor

@HD787 HD787 commented Dec 15, 2024

Description

fixes #3367. The sidebar will now alway open regardless of the last page that it was on.

changing the continueFocusInput command to be more like the navigateTo command may be worth considering, as using cmd+L or open chat quick pick won't take you to the chat page of the sidebar if you're currently on the history page or the more page. This fix works and doesn't have any side effects that I know of, and is important due to #3360 closing the sidebar more frequently.

this code (extensions/vscode/src/commands.ts:475) seems to just stop the process if any page other than the chat page is open.

      const isContinueInputFocused = await sidebar.webviewProtocol.request(
        "isContinueInputFocused",
        undefined,
        false,
      );

Testing

tested on vscode

Copy link

netlify bot commented Dec 15, 2024

Deploy Preview for continuedev canceled.

Name Link
🔨 Latest commit ba751d4
🔍 Latest deploy log https://app.netlify.com/sites/continuedev/deploys/675e27f40de08700082bb048

@sestinj sestinj merged commit 6c499d4 into continuedev:main Dec 15, 2024
12 of 13 checks passed
@HD787 HD787 deleted the chatReopen branch December 16, 2024 05:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

If sidebar is closed while on the history tab, it can't be reopened
2 participants