fix: use the skip default value for skip cli arg
#211
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Even though the defaults for both `skip` and `scripts` were empty objects, the code was referencing the default value for `scripts` in both places, which could lead to a bug in the future if the default for either changed at some point in the future.
e-cloud
approved these changes
Oct 4, 2017
|
@spikegrobstein Awesome, thank you for doing this! I too noticed this problem a while back but never bothered to fix it. |
nexdrew
approved these changes
Nov 21, 2017
|
@nexdrew 👍 go ahead and publish. |
|
@spikegrobstein this change is published now, sorry that took so long! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Even though the defaults for both
skipandscriptswere emptyobjects, the code was referencing the default value for
scriptsinboth places, which could lead to a bug in the future if the default for
either changed at some point in the future.