-
Notifications
You must be signed in to change notification settings - Fork 791
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Can't release because commit does not validate with commitlint #219
Comments
@marionebl I think that the valid types on Valid types are: feat:, fix, docs, style, refactor, perf, test and chore. Basically chore is missing and build, ci and revert should not be allowed. See https://github.com/marionebl/commitlint/pull/143 Regarding the subject, according to angular guidelines it must start with a verb. Changing to |
This is caused by I think we should update standard-version to match the latest conventions. You can fall back to @commitlint/config-angular@4 until that lands. |
@satazor see my comments on #220 I'm not too excited to drop the Edit: Having calmed down from my initial annoyance at the angular spec being made tighter, I'm onboard with making our commits adhere to their new format. At the same time, I would like to set a goal of moving this project towards a |
@bcoe I share the same concerns actually. I think that we should really create a more simpler standard because the new one has some new types that are kind of specific to their needs (e.g.: build vs chore, style..) and introduce unnecessary complexity when deciding. Since commitlint updates their last tag back to 4 this no longer is a emergency and we have time to decide. |
@satazor see conversation here, @marionebl has done a great job of outlining some of the work that we'd need to take on to simplify the commit conventions. |
Using,
with standard version, fails with:
Perhaps the type and message need to be adjusted?
//cc @marionebl @bcoe
The text was updated successfully, but these errors were encountered: