-
Notifications
You must be signed in to change notification settings - Fork 798
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: allows seperate prefixTag version sequences #573
Conversation
there's conflicts I'll fix them on the weekend and update |
@jahead don't forget that please. :) |
Codecov Report
@@ Coverage Diff @@
## master #573 +/- ##
=======================================
Coverage 97.71% 97.71%
=======================================
Files 24 24
Lines 1051 1052 +1
=======================================
+ Hits 1027 1028 +1
Misses 24 24
Continue to review full report at Codecov.
|
Done. Sorry for taking so long. Let me know if anything else is needed |
@@ -66,7 +66,7 @@ function mock ({ bump, changelog, tags }) { | |||
} | |||
})) | |||
|
|||
mockery.registerMock('git-semver-tags', function (cb) { | |||
mockery.registerMock('git-semver-tags', function (_, cb) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@jahead this is looking good to me, but any chance we could add a test that covers the additional functionality?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yea mate, I"ll do it tonight.
I was thinking how to test this
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@bcoe Hey so I added some tests here and tested tagPrefix in general, as there didn't seem to be any tests already that I could see.
I'm not overly happy with is this as git-semver-tags
actually is the one filtering the tags, and due to the mock we won't know if git-semver-tags
changes will break the logic here. But the tests cover the use case in #702
resolve if you're happy
Oddly, through testing this.
Which means that if there is a It will solve #702 but people should take care to configure no packageFiles. I'm not sure we should solve that problem in this PR, but it did seem like odd to me. |
@jahead released in I do gradually try to make my way through @ messages on GitHub, so feel free to keep engaging in this way. |
Solves #572