Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump deps #287

Closed
wants to merge 3 commits into from
Closed

Bump deps #287

wants to merge 3 commits into from

Conversation

LinusU
Copy link

@LinusU LinusU commented Dec 12, 2018

@LinusU LinusU mentioned this pull request Dec 12, 2018
@@ -52,7 +51,7 @@ function outputChangelog (args, newVersion) {

function createIfMissing (args) {
try {
accessSync(args.infile, fs.F_OK)
fs.accessSync(args.infile)
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

F_OK is the default so removed that since fs.F_OK is also deprecated in favor of fs.constants.F_OK

@coveralls
Copy link

Coverage Status

Coverage remained the same at 100.0% when pulling 10b5c8f on LinusU:bump-deps into 844cde6 on conventional-changelog:master.

1 similar comment
@coveralls
Copy link

Coverage Status

Coverage remained the same at 100.0% when pulling 10b5c8f on LinusU:bump-deps into 844cde6 on conventional-changelog:master.

Copy link
Member

@stevemao stevemao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@bcoe
Copy link
Member

bcoe commented Feb 14, 2019

@LinusU I apologize, I created a conflict with your branch while patching some security issues. Suppose I could get you to rebase?

@bcoe
Copy link
Member

bcoe commented May 5, 2019

renovate bot should now hopefully be setup to perform this action automatically.

@bcoe bcoe closed this May 5, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

4 participants