Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: modernize build using esbuild #1684

Merged
merged 7 commits into from
Oct 10, 2023
Merged

fix: modernize build using esbuild #1684

merged 7 commits into from
Oct 10, 2023

Conversation

luwes
Copy link
Collaborator

@luwes luwes commented Oct 3, 2023

Webpack is not a great fit for bundling libraries and the version 4 that is used here is pretty outdated, this PR changes the build commands to use esbuild which is a lot faster and does not require Babel nowadays.

Webpack is better suited for the demo app but it's so minimal that we can get away with using esbuild (serve) and plain CSS instead of SASS. This will allow us to remove a bunch of dependencies and configuration.

  • esbuild library bundles
  • esbuild demo with new build process
  • remove Babel w/ possible test tool replacement
  • verify bundles are working as intended
    verified locally by pasting the iife bundles in the readme js fiddles
    we might have to do a canary/beta release first to verify bundling

@luwes luwes changed the title fix: modernize build using esbuild (WIP) fix: modernize build using esbuild Oct 3, 2023
@luwes luwes force-pushed the esbuild branch 2 times, most recently from a33f82f to d76daf9 Compare October 6, 2023 14:21
@luwes luwes marked this pull request as ready for review October 6, 2023 15:44
Copy link
Owner

@cookpete cookpete left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks awesome. Nice work!

@luwes luwes merged commit 8a4a9aa into cookpete:master Oct 10, 2023
3 checks passed
@luwes luwes deleted the esbuild branch October 10, 2023 17:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants