-
-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: modernize build using esbuild #1684
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
move to examples folder so more apps could be added
luwes
changed the title
fix: modernize build using esbuild (WIP)
fix: modernize build using esbuild
Oct 3, 2023
luwes
force-pushed
the
esbuild
branch
2 times, most recently
from
October 6, 2023 14:21
a33f82f
to
d76daf9
Compare
cookpete
approved these changes
Oct 10, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks awesome. Nice work!
This was referenced Oct 10, 2023
Closed
This was referenced Sep 8, 2024
This was referenced Sep 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Webpack is not a great fit for bundling libraries and the version 4 that is used here is pretty outdated, this PR changes the build commands to use esbuild which is a lot faster and does not require Babel nowadays.
Webpack is better suited for the demo app but it's so minimal that we can get away with using esbuild (serve) and plain CSS instead of SASS. This will allow us to remove a bunch of dependencies and configuration.
verified locally by pasting the iife bundles in the readme js fiddles
we might have to do a canary/beta release first to verify bundling