Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Techdocs allow ignoring folders for dependencies #477

Open
ianrobrien opened this issue Nov 8, 2022 · 1 comment
Open

Techdocs allow ignoring folders for dependencies #477

ianrobrien opened this issue Nov 8, 2022 · 1 comment

Comments

@ianrobrien
Copy link
Contributor

ianrobrien commented Nov 8, 2022 •
edited
Loading

There is an issue that in storm-121 vendor modules are being linted/checked. These cause the CI to fail because there are issues that are detected.

Since we do not modify the code in the vendor directory, could we just allow ignoring it?

This happened due to a push by @dependabot that added markdown files.

https://github.com/coopnorge/storm-121/actions/runs/3417166267/jobs/5689010932

(Although I believe we are moving against vendoring.)
@ianrobrien
Copy link
Contributor Author

FYI I was able to get around this by just pushing to main. The image will run a diff against the main branch so when it runs in main there is effectively no diff.

@ianrobrien ianrobrien assigned ianrobrien and unassigned ianrobrien Nov 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@ianrobrien