Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

export: COQ_IMAGE is ignored #91

Closed
JasonGross opened this issue May 10, 2024 · 2 comments
Closed

export: COQ_IMAGE is ignored #91

JasonGross opened this issue May 10, 2024 · 2 comments
Labels
question Further information is requested

Comments

@JasonGross
Copy link
Member

Why is there no -e COQ_IMAGE despite me listing export: COQ_IMAGE?
https://github.com/mit-plv/fiat-crypto/actions/runs/9028790464/job/24809895511#step:19:44

Run coq-community/docker-coq-action@v1
  with:
    coq_version: dev
    ocaml_version: default
    export: CI ALLOW_DIFF COQCHKEXTRAFLAGS GITHUB_STEP_SUMMARY COQ_IMAGE
    custom_script: printf "'%s'\n" "${COQ_IMAGE}"
  printf "%s" "${COQ_IMAGE}" > .coqimage
  
    opam_file: .
    before_install: startGroup "Print opam config"
    opam config list; opam repo list; opam list
  endGroup
  
    install: startGroup "Install dependencies"
    sudo apt-get update -y -q
    opam pin add -n -y -k path $PACKAGE $WORKDIR
    opam update -y
    opam install --confirm-level=unsafe-yes -j 2 $PACKAGE --deps-only
  endGroup
  
    after_install: startGroup "List installed packages"
    opam list
  endGroup
  
    script: startGroup "Build"
    opam install -y -v -j 2 $PACKAGE
    opam list
  endGroup
  
    uninstall: startGroup "Uninstallation test"
    opam remove -y $PACKAGE
  endGroup
  
  env:
    COQ_VERSION: master
    DOCKER_COQ_VERSION: dev
    DOCKER_OCAML_VERSION: default
    SKIP_VALIDATE: 
    COQCHKEXTRAFLAGS: -bytecode-compiler yes
    EXTRA_GH_REPORTIFY: --warnings
    ALLOW_DIFF: 1
    CI: 1
/usr/bin/docker run --name e39f5008ac7d946e449e1981db514cb3a30c6_940f15 --label 3e39f5 --workdir /github/workspace --rm -e "COQ_VERSION" -e "DOCKER_COQ_VERSION" -e "DOCKER_OCAML_VERSION" -e "SKIP_VALIDATE" -e "COQCHKEXTRAFLAGS" -e "EXTRA_GH_REPORTIFY" -e "ALLOW_DIFF" -e "CI" -e "INPUT_COQ_VERSION" -e "INPUT_OCAML_VERSION" -e "INPUT_EXPORT" -e "INPUT_CUSTOM_SCRIPT" -e "INPUT_OPAM_FILE" -e "INPUT_BEFORE_INSTALL" -e "INPUT_INSTALL" -e "INPUT_AFTER_INSTALL" -e "INPUT_BEFORE_SCRIPT" -e "INPUT_SCRIPT" -e "INPUT_AFTER_SCRIPT" -e "INPUT_UNINSTALL" -e "INPUT_CUSTOM_IMAGE" -e "HOME" -e "GITHUB_JOB" -e "GITHUB_REF" -e "GITHUB_SHA" -e "GITHUB_REPOSITORY" -e "GITHUB_REPOSITORY_OWNER" -e "GITHUB_REPOSITORY_OWNER_ID" -e "GITHUB_RUN_ID" -e "GITHUB_RUN_NUMBER" -e "GITHUB_RETENTION_DAYS" -e "GITHUB_RUN_ATTEMPT" -e "GITHUB_REPOSITORY_ID" -e "GITHUB_ACTOR_ID" -e "GITHUB_ACTOR" -e "GITHUB_TRIGGERING_ACTOR" -e "GITHUB_WORKFLOW" -e "GITHUB_HEAD_REF" -e "GITHUB_BASE_REF" -e "GITHUB_EVENT_NAME" -e "GITHUB_SERVER_URL" -e "GITHUB_API_URL" -e "GITHUB_GRAPHQL_URL" -e "GITHUB_REF_NAME" -e "GITHUB_REF_PROTECTED" -e "GITHUB_REF_TYPE" -e "GITHUB_WORKFLOW_REF" -e "GITHUB_WORKFLOW_SHA" -e "GITHUB_WORKSPACE" -e "GITHUB_ACTION" -e "GITHUB_EVENT_PATH" -e "GITHUB_ACTION_REPOSITORY" -e "GITHUB_ACTION_REF" -e "GITHUB_PATH" -e "GITHUB_ENV" -e "GITHUB_STEP_SUMMARY" -e "GITHUB_STATE" -e "GITHUB_OUTPUT" -e "RUNNER_OS" -e "RUNNER_ARCH" -e "RUNNER_NAME" -e "RUNNER_ENVIRONMENT" -e "RUNNER_TOOL_CACHE" -e "RUNNER_TEMP" -e "RUNNER_WORKSPACE" -e "ACTIONS_RUNTIME_URL" -e "ACTIONS_RUNTIME_TOKEN" -e "ACTIONS_CACHE_URL" -e "ACTIONS_RESULTS_URL" -e GITHUB_ACTIONS=true -v "/var/run/docker.sock":"/var/run/docker.sock" -v "/home/runner/work/_temp/_github_home":"/github/home" -v "/home/runner/work/_temp/_github_workflow":"/github/workflow" -v "/home/runner/work/_temp/_runner_file_commands":"/github/file_commands" -v "/home/runner/work/fiat-crypto/fiat-crypto":"/github/workspace" 3e39f5:008ac7d946e449e1981db514cb3a30c6
@erikmd
Copy link
Member

erikmd commented May 11, 2024

Maybe because you use coq-community/docker-coq-action@v1, not coq-community/docker-coq-action@master (?)

(As I only merged the COQ_IMAGE PR in master, and the v1 is updated just for a new release… which will be done soonish anyway! after documenting this and #90)

@erikmd erikmd added needs: test question Further information is requested and removed needs: test labels May 11, 2024
@erikmd
Copy link
Member

erikmd commented May 12, 2024

Test added and works as expected.

@erikmd erikmd closed this as completed May 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
question Further information is requested
Projects
None yet
Development

No branches or pull requests

2 participants