Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Documentation errors #3508

Closed
xvdp opened this issue Jan 10, 2024 · 1 comment
Closed

Documentation errors #3508

xvdp opened this issue Jan 10, 2024 · 1 comment
Labels
bug Something isn't working wontfix This will not be worked on but feel free to help.

Comments

@xvdp
Copy link

xvdp commented Jan 10, 2024

Describe the bug

different docs describe commands differently and not always correctly.

https://docs.coqui.ai/en/latest/ and the github README say this

from TTS.api import TTS
print(TTS().list_models())
# <TTS.utils.manage.ModelManager object at 0x7f1441bc8c70>

however the previous returns the manager, not the list, so this would be the correct command.

print(TTS().list_models().list_models())

Although I agree that this looks weird.

If instead you look inside TTS/api.py which is the first thing I did to to see where the first error was coming from, the first example line for TTS.__init__(), line 30, states

Example with a multi-speaker model:
>>> from TTS.api import TTS
>>> tts = TTS(TTS.list_models()[0])
# which natturally yields an error
# TypeError: list_models() missing 1 required positional argument: 'self'

the bash variant to that command works as advertised

tts --list_models

Aside from these, the project looks great, I just wanted to point out some confusing directions.

To Reproduce

git clone and install

I installed within my own Dockerimage, first locally cloning
git clone "https://github.com/coqui-ai/TTS"
then pip installing

ADD --chown=appuser:appuser TTS TTS
RUN pip install --no-cache-dir TTS/.

Expected behavior

No response

Logs

No response

Environment

/collect_env_info.py
{
    "CUDA": {
        "GPU": [
            "NVIDIA GeForce RTX 3080 Ti Laptop GPU"
        ],
        "available": true,
        "version": "12.1"
    },
    "Packages": {
        "PyTorch_debug": false,
        "PyTorch_version": "2.1.2",
        "TTS": "0.22.0",
        "numpy": "1.22.0"
    },
    "System": {
        "OS": "Linux",
        "architecture": [
            "64bit",
            ""
        ],
        "processor": "x86_64",
        "python": "3.9.18",
        "version": "#40~22.04.1-Ubuntu SMP PREEMPT_DYNAMIC Thu Nov 16 10:53:04 UTC 2"
    }
}

Additional context

No response

@xvdp xvdp added the bug Something isn't working label Jan 10, 2024
Copy link

stale bot commented Feb 10, 2024

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. You might also look our discussion channels.

@stale stale bot added the wontfix This will not be worked on but feel free to help. label Feb 10, 2024
@stale stale bot closed this as completed Feb 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working wontfix This will not be worked on but feel free to help.
Projects
None yet
Development

No branches or pull requests

1 participant