Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Switch to stable rust #38

Closed
armaniferrante opened this issue Jan 23, 2021 · 2 comments
Closed

Switch to stable rust #38

armaniferrante opened this issue Jan 23, 2021 · 2 comments
Labels
priority:3

Comments

@armaniferrante
Copy link
Member

armaniferrante commented Jan 23, 2021 •
edited
Loading

Requires the solana bpf sdk to be on Rust 1.45 or above, so that we can remove #![feature(proc_macro_hygiene)] everywhere.

Until we do this, CI will sometimes fail, because rustfmt is not always available on the latest nightly, so travis should also probably pin the nightly version.
@armaniferrante
Copy link
Member Author

Blocked on the solana sdk, so labeling as p3.

@armaniferrante armaniferrante mentioned this issue Mar 16, 2021
Closed
@armaniferrante armaniferrante changed the title Remove #![feature(proc_macro_hygiene)] everywhere Switch to stable rust Mar 27, 2021
@armaniferrante armaniferrante mentioned this issue Mar 27, 2021
Merged
@armaniferrante armaniferrante mentioned this issue Apr 3, 2021
Merged
@armaniferrante
Copy link
Member Author

Addressed by #139.

@tanmaymunjal tanmaymunjal mentioned this issue Apr 9, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
priority:3
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@armaniferrante