Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Accounts example? #31

Open
manosbatsis opened this issue Oct 27, 2020 · 1 comment
Open

Accounts example? #31

manosbatsis opened this issue Oct 27, 2020 · 1 comment

Comments

@manosbatsis
Copy link
Contributor

manosbatsis commented Oct 27, 2020

Started looking at migrating Corbean's BNMS starter from the old Corda Solutions imlementation to the this bn-extension. It's late and i'm a bit dizzy so please bear with me and a couple of questions:

  • It it fair to say the new BNIdentity interface largely replaces the old Membership metadata in terms of customisation purposes (excluding groups/roles)?
  • Is it possible to use any existing or custom implementation of BNIdentity to assign groups and/or roles to Corda Accounts?
  • If no accounts-aware implementation is readily available, does the extension support multiple MembershipStates with the same MembershipIdentity.cordaIdentity but different MembershipIdentity.businessIdentity? The reason I'm asking is because BNService methods like .getMembership() seem to assume a single result per networkId and Party combination which, in my understanding and the case of Corda Accounts, beats the purpose of allowing a custom BNIdentity implementation in the first place. Unless of course one can roll out their own BNService-ish replacement as a Corda Service to work around current service API limitations via custom criteria queries/logic and so on.
@manosbatsis
Copy link
Contributor Author

@tubibuto @bpaunescu: After our discussion in #33 would you be interested in a PR that

  • Provides additional service methods or stand-alone service without the assumption of only single result per networkId and Party combination
  • Adds method signatures to accept additional query criteria

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant