Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

wal: release wal locks before renaming directory on init #5855

Merged
merged 1 commit into from
Jul 4, 2016

Conversation

heyitsanthony
Copy link
Contributor

Brokenness of master on windows confirmed; works with patch.

Fixes #5852

/cc @xiang90 @MartyMacGyver

return nil, err
}

w.fp = newFilePipeline(w.dir, segmentSizeBytes)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why do we delete this?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Open will create the file pipeline

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Right. thanks.

@MartyMacGyver
Copy link
Contributor

Thank you! I rebuilt coreos:master from source with this change in it, and it worked for me as well.

Question: Other than cloning etc with your change and running build.bat, did you go through any other steps before building this on Windows? I've been looking for documentation on building via build.bat and haven't found anything (it clearly works, with some spurious "The directory name is invalid." build initialization errors that don't appear to affect the build itself).

@xiang90
Copy link
Contributor

xiang90 commented Jul 3, 2016

lgtm

@heyitsanthony
Copy link
Contributor Author

@MartyMacGyver just build.bat should do it. Please open an issue for the error messages? Thanks!

@heyitsanthony heyitsanthony merged commit b566ca2 into etcd-io:master Jul 4, 2016
@MartyMacGyver
Copy link
Contributor

@heyitsanthony I'll investigate and then open an issue or two (the how-to-build docs and release notes could use some enhancements in regard to the right way to build and use this in Windows, including prerequisites (e.g., probably need NTFS if you expect to re-create symlinks with Junction calls).

Thanks again for the quick turnaround on this bug!

@heyitsanthony heyitsanthony deleted the fix-windows-wal-init branch July 6, 2016 20:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

4 participants